Implement Redesign of whole application #1069
Commits on Jun 7, 2023
-
Remove code to make single page apps work on GitHub pages
In the redesign, we won't be using a router anymore, so no need to redirect other paths to `index.html`.
-
Make a fresh start: setup basic color scheme logic
The dark mode colors are just the light mode ones in reverse. This will still change!
-
-
Replace theme-ui with just emotion-js
We use emotion in our other projects as well and theme-ui just adds some features to emotion that we don't really need. It also causes certain problems.
-
With CRA we are forced to annotate the JSX thing in each file. It also has lots of other problems, from slow updates, over not being able to configure certain things, to unexpected magic behavior. This commit just ran `npm run eject`. This left a mess which will be cleaned up in the next commits.
-
Most majority of
srcfiles intoold-srcThis it to get them out of the way for now.
-
-
-
Make almost all lints warnings
They should not stop you from viewing the app. These are things that are sufficient to fix before committing.
-
Commits on Jun 21, 2023
-
-
I don't know how many times we already switched from one to another. Now it's a good time to stick to the community style from the shared ESLint config though. There are some advantages to double quotes.
Commits on Jun 27, 2023
Commits on Jun 28, 2023
Commits on Jul 6, 2023
-
-
-
Add step progress bar indicator
This still needs accessibility features!
Commits on Jul 13, 2023
Commits on Jul 17, 2023
-
-
-
Switch to completely grey neutral colors
This was updated in appkit a while ago but I forgot to update it here.
-
-
-
-
Commits on Jul 19, 2023
Commits on Jul 24, 2023
-
-
Disable shortcut overlay on mouseclick or any key up event
Otherwise the overlay could stick around when alt-tabbing outside the app and not knowing to press alt.
-
-
Re-add redesigned fourth step (review & cut)
Only thing missing: scrubber redesign
-
-
-
-
-
-
-
Add draggable playhead and improve dragging controls a lot
This finishes the redesign of the review step.
Commits on Jul 25, 2023
Commits on Jul 27, 2023
Commits on Jul 31, 2023
-
-
-
Add shortcuts to "finish" step
There is no shortcut for "upload" as you are inside the form anyway and can just press enter.
Commits on Aug 1, 2023
-
-
-
-
-
Remove box shadow of video-preference hovering button
To make it visible on dark background, an invert backdrop filter is used instead.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Decrease size of gear-icon for video prefs
Feedback from Olaf: that's too large. And I agree, the smaller one is still fine.
-
-
-
-
-
-
Commits on Aug 2, 2023
-
-
-
-
-
-
-
-
-
Remove
theme.customCSSsettingIn the future, we might re-introduce a similar setting that would allow modifying the accent color. Doing that in a way that prevents people from accidentally introducing accessibility problems is not trivial. That's why it's not included in the main PR. Also, this custom CSS thing was quite hacky and fragile. We never officially supported/encouraged overriding CSS variables. So replacing this with a less brittle version is a good idea anyway.
-
-
-
Remove all of the remaining
old-srcfolderI looked through the code and saw nothing that's still missing from the redesign.
-
-
-
Explicitly ignore remaining
anyusages to enable fully strict modeIncluding `noImplicitAny`. Having the compiler catch accidental usages of `any` is worth those three explicit annotations.
-
Remove outdated "tests" section in contributing docs
Note that this redesign PR did not remove the tests. There were never real tests to begin with. OC Studio is very hard to UI test due to the interaction with screen and webcam capture. That's why we never had useful tests.
-
These were useful in JS days, but now with TS there is no real point in having a constant for a fixed string, which will be type checked anyway.
-
Add eslint rule to enforce consistent member delimiter style
This is in line with the Tobira eslint rule
-
Commits on Aug 21, 2023
-
-
Show "reselect sources" button in video select if there is a problem
Before, users were forced to reload the page.
-
Add
Skey as alternative to "Alt" for showing available shortcutsThe Alt key unfortunately often causes the Browser to do stuff as well.
-
Slightly improve contrast of step buttons
This is especially useful for dark mode, where they had a fairly low contrast.
-
Change next/back shortcuts on mac to shift+cmd+arrow
The previous cmd+arrow is used by the browser for forwards/backwards navigation. This specific shortcut was suggested by Julian.
Commits on Aug 22, 2023
-
Improve
<select>by removing browser styles and use custom arrowIt looked terrible in Safari before. And now the arrow is also the same cross browser.
-
Fix recording in Safari by actually calling
stopThat was a stupid oversight before and I'm not sure how it even works in other browsers. This is quite the diff as I had to pull lots of logic from the recording controls to the parent component.
Commits on Aug 24, 2023
-
Hide video settings button when there is no stream
There is a tiny chance that changing settings or the device could make the error go away actually. But this is so unlikely, that it's not worth confusing all other users with.
-
This also improve contrast issues with some elements.
-
-