Improve link-button a11y #1133
Merged
Improve link-button a11y #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two places where an anchor element is styled as a button. [mdn web docs](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role#accessibility_concerns) says that in addition to `role=button`, these also need an extra handler to be usable with the `space` key (which is default button behaviour and therefore expected with things that are styled as buttons). Closes elan-ev#630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two places where an anchor element is styled as a button.
Mdn web docs says that in addition to
role=button, these also need an extra handler to be usable with thespacekey (which is default button behaviour and therefore expected with things that are styled as buttons).The other part of #630 (
aria-livefor error messages) appears to be done already.Closes #630