-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup translations and remove Turkish & Greek #1135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are removed from other languages later!
The English word was "back", so using `prev` is a bit weird. The type in code wasn't changed though.
These transitioned already into the "nested style". Instead of just removing all old ones, we move them to preserve the translation.
Don't know how that happened, wupps.
Both languages had a super low translation percentage with most strings missing. I also don't currently see who could improve the situation. So removing them for now, keeping the few translations in git history. At some point, we will use Crowdin again, hopefully somewhat improving that situation. Farsi has even fewer translated strings, but a colleague (Farbod) offered help in that regard, so keeping for now.
owi92
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1075
This moves around translations (i.e. giving them a different key), mostly to transition to the nested form. This PR also removes unused translations. Not all keys are in the nested form yet as
I lost motivation at this pointsome are just used in several places and don't fit well into the nested structure. Finally, Greek and Turkish are removed. See the relevant commit for more info.This is quite a big and annoying-to-review PR, unfortunately. I don't think a code review is useful or necessary:
en.json
. Thus, all used translation keys at least exist in the English file!t(`foo-${yes ? "cat" : "dog"}`)
. Which Typescript is able to understand, but grep doesn't of course. So for those false positives "unused" translations I checked again manually. And again: I can't accidentally remove one that is still used, as Typescript will complain.I already asked and will still ask a few contacts to provide full translations for French, Farsi, Spanish, Chinese simplified. Those will be added in a follow up PR.
My used scripts, just for reference:
flatten.ts
: prints the flat translation keys of a JSON file. Run withdeno --allow-read flatten.ts -- path/to/file
.Run that for
en.json
and save toenkeys.txt
. Then run this script on the output offlatten.ts
for all other files: