Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable series selection to upload step #1143

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

LukasKalbertodt
Copy link
Member

@LukasKalbertodt LukasKalbertodt commented Oct 18, 2023

Closes #777
Replaces #992

This is #992 rebased on the redesign. Well, since so much changed, it's almost more of a reimplementation than just a rebase.

If upload.seriesId is set, then that series is pre-selected in the series-selector, but the user can still change it. If organizations want the old behavior, they need to set upload.seriesField=hidden.

Test Deployment

@geichelberger Can you review and/or test this? If it meets all your requirements? Or is someone else better suited to answer the latter question? I can also find someone here at ELAN to do the code review, if you don't have the time. Just let me know!

@majosch
Copy link
Contributor

majosch commented Nov 8, 2023

@LukasKalbertodt Thank you. At University of Vienna we are desperately in need for this feature 😅

We did some testing on our "upstream" Opencast installation, that is built from develop-branch - and on our "staging" instance with Opencast 14.x and backported PR4651 . Works as expected on both instances - also if deployed as "standalone".

Copy link
Contributor

@geichelberger geichelberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONFIGURATION.md Outdated Show resolved Hide resolved
LukasKalbertodt and others added 2 commits November 8, 2023 10:19
This allows users to select a series to associate the uploaded video
with. They can select from all series that they have write access to.
The series field can be configured just like the two other fields:
being hidden, optional or required.

Co-Authored-By: Gregor Eichelberger <gregor.eichelberger@tuwien.ac.at>
The didn't break anything, but made Studio warn about it.
@LukasKalbertodt LukasKalbertodt merged commit 6a81db7 into elan-ev:master Nov 8, 2023
2 checks passed
@LukasKalbertodt LukasKalbertodt deleted the series-selection branch November 8, 2023 09:35
@LukasKalbertodt
Copy link
Member Author

I created a release and opened the PR against Opencast to update Studio, such that this feature will be included in the upcoming OC 15: opencast/opencast#5418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature A completely new feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dropdown selection of series or show series name if series ID has been given
3 participants