Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update French strings #1149

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Update French strings #1149

merged 2 commits into from
Nov 13, 2023

Conversation

Badatos
Copy link
Contributor

@Badatos Badatos commented Nov 13, 2023

Hello!
Thank you for this amazing new studio version!
Here is an updated french translation ;)

Have a nice day,

LukasKalbertodt
LukasKalbertodt approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks a lot! Also for fixing the outdated variable in the readme.

As usual with translation PRs, I will just fully trust you. I don't speak French at all. I like the guillemets, but the space before ! and ? just scares me :D

Thanks again!

@LukasKalbertodt LukasKalbertodt merged commit 2dacb34 into elan-ev:master Nov 13, 2023
2 checks passed
@Badatos
Copy link
Contributor Author

Badatos commented Nov 14, 2023

Thanks for the quick approval!
Don't worry too much about the spaces before ! and ?: they're just non-breaking spaces needed in French to ensure that the punctuation is never far from the text ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Badatos @LukasKalbertodt