Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable settings path #488

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Configurable settings path #488

merged 3 commits into from
Mar 19, 2020

Conversation

LukasKalbertodt
Copy link
Member

Closes #487

@LukasKalbertodt LukasKalbertodt mentioned this pull request Mar 18, 2020
Merged
lkiesow
lkiesow reviewed Mar 19, 2020
View reviewed changes
Copy link
Contributor

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except that I'm not certain about the path. That's why I would probably just go with an absolute path.

create-release.sh Outdated Show resolved Hide resolved
@LukasKalbertodt @lkiesow
Update create-release.sh
c8e7e9d 
Co-Authored-By: Lars Kiesow <lkiesow@uos.de>
@LukasKalbertodt LukasKalbertodt merged commit 956e376 into elan-ev:master Mar 19, 2020
@LukasKalbertodt LukasKalbertodt deleted the configurable-settings-path branch March 19, 2020 23:24
@LukasKalbertodt LukasKalbertodt mentioned this pull request Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkiesow lkiesow lkiesow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make settings.json configurable in Opencast
2 participants
@LukasKalbertodt @lkiesow