Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file extension and Safari detection #490

Merged

Conversation

LukasKalbertodt
Copy link
Member

Fixes #486
Fixes #485

Studio now also checks for video/x-matroska and sets the file extension to .mkv appropriately. When uploading to OC, the file extension is now also correctly chosen instead of being hardcoded as webm. Finally, the Safari browser detection is fixed.

@mtneug Could you check if this solves your problems? This version is deployed here. If you can't test this today (which is not a problem of course!) it would be great if you could tell me. Thanks!

@mtneug
Copy link

mtneug commented Mar 18, 2020

@LukasKalbertodt thank you. This now properly sets the file extension on my test setup.

@LukasKalbertodt
Copy link
Member Author

@mtneug Great, thanks for testing!

@LukasKalbertodt LukasKalbertodt merged commit 6555864 into elan-ev:master Mar 18, 2020
@LukasKalbertodt LukasKalbertodt deleted the fix-file-extension-again branch March 18, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome on macOS is detected as Safari
2 participants