Refactor and improve handling of settings & add settings about MIME types and video bitrate #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… down This way, deeply nested components can easily access settings without all ancestors need to pass it through.
This improves robustness, provides a single source of truth for how the settings object looks and improves error handling.
LukasKalbertodt
force-pushed
the
mime-in-settings
branch
from
f7c0cae
to
4bfeedc
Compare
lkiesow
pushed a commit
that referenced
this pull request
Mar 19, 2020
#493 from LukasKalbertodt/mime-in-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves how settings are handled throughout the code. In particular, settings are now checked against a specified type and validator.
Two new settings were added which can be used to specify details about the recording process.
Closes #481