-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurations to define ACLs for upload #510
Conversation
If you define an ACL template block like this:
and the user serve studio not from an LTI session. The |
@wsmirnow The block will disappear. See this part of the Mustache documentation. So these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it. Good job.
The value is not used yet!
00349fd
to
b00988e
Compare
#510 from LukasKalbertodt/acl-template
Fixes #477
Fixes #478
A review from @wsmirnow would be appreciated to make sure this system is powerful enough for the customer systems you manage. Your adjustments here should be simple: just take the default ACL template and add the part you added in the linked commit.
This change of yours was a bit more tricky as it required values taken from user roles. But I think with this PR, we can achieve the same effect with this ACL template:
(Note that the
{{ #foo }} bar{{ . }}baz {{ /foo }}
syntax repeatsbar{{ . }}baz
for every element infoo
, with{{ . }}
replace by that element.)