Fix some bugs in opencast connection handling #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Due to the timeout introduced in elan-ev#610, saving settings on slow connections failed. The timeout logic didn't really belong into `init` anyway. - `updateGlobalInstance` had a bug because we didn't update it when introducing the LTI state. Since that method needs updating often and forgetting it can lead to strange bugs, the "changed?" check is simply removed. This might lead to a few extra rerenders, but it's way better than bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
info/meand avoid waiting for initial request for a long time #610, saving settings on slowconnections failed. The timeout logic didn't really belong into
initanyway.updateGlobalInstancehad a bug because we didn't update it whenintroducing the LTI state. Since that method needs updating often
and forgetting it can lead to strange bugs, the "changed?" check is
simply removed. This might lead to a few extra rerenders, but it's
way better than bugs.