-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More customizable CSS #902
Conversation
Hello ! First, I want to thank you for this useful tool. I made some minor CSS change to allow a stand alone opencast server to use more customizable colors, with css vars. Added vars : * --theme-ui-colors-btn-hover (hover bg color for buttons) * --theme-ui-colors-button_fg (button foreground color) * --theme-ui-colors-controls (text color for video player controls) * --theme-ui-colors-info (bg color for an 'info' panel (like in video parameters popup) + add a "role=button" on download link for better accessibility.
Hi @Badatos, thanks for the contribution. |
Hello Lars!
... or another sample :
|
another way is to load opencast app inside another website, and apply directly the main website's CSS; |
Seems like a goood idea. But one thing that is definitely missing from this patch is documentation about this. No one will ever know or remember if we do not add this. Also, this is really hard to use in this form. Users would actually need to modify the code. What if we just add a simple theme = """
:root {
--theme-ui-colors-background: #303238;
--theme-ui-colors-text: #FFF;
}
#root {
--theme-ui-colors-info: #737373;
--theme-ui-colors-gray-3: #797676;
}
""" This would be much more convenient for adopters to use and should be relatively easy to implement. |
…URATION.md to help use it.
Good idea Lars. |
is it ok for you @lkiesow ? |
Hi @Badatos, sorry, I was busy with the Opencast Summit last week and had no time to look at this. Will do so tomorrow. |
Hello @lkiesow. The "npm run build" command does not raise it for me. |
Ok, I see it : it happens when there is no [theme] entry in settings.toml. |
…there is not any.
New commit pushed ! Thank you for the testing @lkiesow, it works now ;) |
Thanks for fixing this. Merged. |
Pull request elan-ev#902 allows users to specify color themes for Studio. The background of the main input selection buttons when hovering over them is unfortunately hard-coded to pure white though, making a dark theme basically impossible to specify. This patch sets the background color dynamically based on the main color instead by just slightly brightening the color. The default looks basically the same and specifying dark themes is now a lot easier.
Hello !
First, I want to thank you for this useful tool.
I made some minor CSS change to allow a stand alone opencast server to use more customizable colors, with css vars.
Added vars :