Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tippyjs-react for Tooltips #931

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

narickmann
Copy link
Contributor

  • added and implemented tippyjs-react
  • added tooltips where it makes sense
  • removed unnecessary title-attributes (e.g. buttons where title-attribute and button-text was the same)
  • added english translation for video-settings-button

- added and implemented tippyjs-react
- added tooltips where it makes sense
- removed unnecessary title-attributes (e.g. buttons where title-attribute and button-text was the same)
- added english translation for video-settings-button
@lkiesow
Copy link
Contributor

lkiesow commented May 20, 2022

@lkiesow lkiesow merged commit bdfb82a into elan-ev:master May 20, 2022
@LukasKalbertodt
Copy link
Member

I realize this is already merged, but some quick notes, maybe for a follow up PR:

  • I would prefer if the tooltip would appear instantly instead of slowly getting visible. When disappearing a transition-effect is fine, but when appearing, it feels laggy IMO. And you can miss that there even is a tooltip.

  • The tooltip over the video settings cog could be higher? It hides a bit of the cog even.

  • There is still a fairly useless title attribute on the upload button, I think

Other than that, great work. Every element that could use a tooltip has one, and every element where a tooltip would be useless has none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants