Fix master deployment by not removing build artifacts #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is, that we want the test deployment and the production deployment for `master`. But both workflows delete the build artifacts after downloading them. So only one gets it, the other one fails. This is solved by just not deleting build artifacts. The build artifacts for Studio are very small (1.4MB) or so, so even with lots of parallel builds, it's unlikely we will reach GitHub's limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is, that we want the test deployment and the
production deployment for
master. But both workflows deletethe build artifacts after downloading them. So only one gets it,
the other one fails.
This is solved by just not deleting build artifacts.
The build artifacts for Studio are very small (1.4MB) or so, so
even with lots of parallel builds, it's unlikely we will reach
GitHub's limit.