[locales/fr.json] correct some typos on french strings #953

Badatos · 2022-07-19T13:13:52Z

[Accessibility] add missing labels on some "select" boxes
string "Language" (in settings) can now be localised

Corrections on french strings :

add missing non breakable spaces before double ponctuations
correct some accords (like "la vidéo téléchargé" -> "la vidéo téléchargée")
use curvy quote (see http://cesarx.free.fr/de_la_typo.html)

* add missing non breakable spaces before double ponctuations * correct some accords (like "la vidéo téléchargé" -> "la vidéo téléchargée") * use curvy quote (see http://cesarx.free.fr/de_la_typo.html)

+ string "Language" can now be localised

Badatos · 2022-07-20T09:17:26Z

Hello There. This PR has been tested and is ready for review. Have a nice day ;)

LukasKalbertodt

Hi there and thanks for your PR! As with all languages that I don't know, I obviously can't verify these changes, but it doesn't look like you sneaked any swearwords into this 😁

I only have one comment below. After that is resolved, I'm happy to merge.

LukasKalbertodt · 2022-08-01T07:26:24Z

src/ui/settings/language.js

-    <SettingsSection title="Language">
+    <SettingsSection title={i18n.t('settings-general-header')}>
+      <label
+        htmlFor='studio-lang'
+        sx={{ variant: 'styles.label' }}
+      >
+        {i18n.t('settings-language-label')}
+      </label>
      <select
+        id="studio-lang"


We actually explicitly kept "Language" untranslated. If you set Studio to some weird language, you still want to find the language selection, and we figured most people know what "language" means. We plan on improving this a lot in the future via some redesign.

So, could you remove this part of the change (including the new translation strings).

Regarding adding a label to this and other drop-down menus: is this mainly for accessibility? I'm not quite sure what this change is for. I'm fully on board with the change for the audio and video device (as it doesn't change anything about what's visible), but I'm not sure it's useful in this language case?

Ok ! It make sense, yes ;) Maybe we can keep both : translated string + "Language" between parenthesis ?

Adding the labels is mandatory for accessibility yes.

to evaluate accessibility level of a web page, I recommend the "Wave" tool : https://wave.webaim.org/ which can be installed as a plugin in your web browser.

I do know Wave and have it permanently installed actually. I guess I just never checked these Studio things, probably because due to the lack of time, but likely also because not long ago, Studio had way more serious accessibility concerns :D

…e weird language, you still want to find the language selection, and we figured most people know what "language" means. We plan on improving this a lot in the future via some redesign.)

Badatos · 2022-08-01T09:30:59Z

I just made a commit which display "Language" string both translated + untranslated. Is it ok for you ?

LukasKalbertodt · 2022-08-01T10:37:41Z

Yep, keeping both sounds good! But can you hide the second / Language when the language is English? Should be easy to do and looks really weird otherwise. And while you're at it, could you replace the first line with const { i18n, t } = useTranslation(); (note the added t) and then use t instead of i18n.t for translating? It's a minor thing, but makes it consistent with the existing code. Then I'm happy to merge!

Badatos · 2022-08-01T12:53:24Z

Yep, keeping both sounds good! But can you hide the second / Language when the language is English? Should be easy to do and looks really weird otherwise. And while you're at it, could you replace the first line with const { i18n, t } = useTranslation(); (note the added t) and then use t instead of i18n.t for translating? It's a minor thing, but makes it consistent with the existing code. Then I'm happy to merge!

You're right : it looks weird in english ;) I try to hide it on this case.

+ use t instead of i18n.t for translating (makes it consistent with the existing code.)

Badatos · 2022-08-01T13:09:39Z

Here's the new commit including :

Hide the second "/ Language" when the language is English
use t instead of i18n.t for translating (makes it consistent with the existing code.)

LukasKalbertodt

Terribly sorry to request changes again :D But for languages where "language" is not translated, it falls back to English, so they still have the "Language / Language" problem. As shown below, I would just literally check whether the string is "English".

src/ui/settings/language.js

LukasKalbertodt · 2022-08-01T13:57:26Z

I was so free as to just apply my suggestion. Now I'm happy :D Thank you again for the PR!

Badatos · 2022-08-01T14:11:43Z

Thank you for the merge and your review : all your remarks are pertinent and it's how we make things better ;) Have a nice day !

Badatos added 4 commits July 19, 2022 15:12

[locales/fr.json] correct some typos on french strings

0fe2d17

* add missing non breakable spaces before double ponctuations * correct some accords (like "la vidéo téléchargé" -> "la vidéo téléchargée") * use curvy quote (see http://cesarx.free.fr/de_la_typo.html)

New typos on fr strings

6f78c99

Add missing french strings

9a54417

Accessibility : add missing labels on some "select" boxes

268b8d0

+ string "Language" can now be localised

LukasKalbertodt requested changes Aug 1, 2022

View reviewed changes

Badatos added 2 commits August 1, 2022 11:23

Merge branch 'master' of https://github.com/elan-ev/opencast-studio

cb03ace

[i18n] Keep a "Language" string untranslated (If Studio is set to som…

d5ca6b3

…e weird language, you still want to find the language selection, and we figured most people know what "language" means. We plan on improving this a lot in the future via some redesign.)

Hide the second "/ Language" when the language is English

3024ae0

+ use t instead of i18n.t for translating (makes it consistent with the existing code.)

LukasKalbertodt requested changes Aug 1, 2022

View reviewed changes

src/ui/settings/language.js Outdated Show resolved Hide resolved

Address review comments

c906340

LukasKalbertodt merged commit d0b81ea into elan-ev:master Aug 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[locales/fr.json] correct some typos on french strings #953

[locales/fr.json] correct some typos on french strings #953

Badatos commented Jul 19, 2022 •

edited

Loading

Badatos commented Jul 20, 2022

LukasKalbertodt left a comment

LukasKalbertodt Aug 1, 2022

Badatos Aug 1, 2022 •

edited

Loading

Badatos Aug 1, 2022

LukasKalbertodt Aug 1, 2022

Badatos commented Aug 1, 2022

LukasKalbertodt commented Aug 1, 2022

Badatos commented Aug 1, 2022

Badatos commented Aug 1, 2022

LukasKalbertodt left a comment

LukasKalbertodt commented Aug 1, 2022

Badatos commented Aug 1, 2022

[locales/fr.json] correct some typos on french strings #953

[locales/fr.json] correct some typos on french strings #953

Conversation

Badatos commented Jul 19, 2022 • edited Loading

Badatos commented Jul 20, 2022

LukasKalbertodt left a comment

Choose a reason for hiding this comment

LukasKalbertodt Aug 1, 2022

Choose a reason for hiding this comment

Badatos Aug 1, 2022 • edited Loading

Choose a reason for hiding this comment

Badatos Aug 1, 2022

Choose a reason for hiding this comment

LukasKalbertodt Aug 1, 2022

Choose a reason for hiding this comment

Badatos commented Aug 1, 2022

LukasKalbertodt commented Aug 1, 2022

Badatos commented Aug 1, 2022

Badatos commented Aug 1, 2022

LukasKalbertodt left a comment

Choose a reason for hiding this comment

LukasKalbertodt commented Aug 1, 2022

Badatos commented Aug 1, 2022

Badatos commented Jul 19, 2022 •

edited

Loading

Badatos Aug 1, 2022 •

edited

Loading