Switch from single-quote in JSX to double-quotes #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is closer to normal HTML and is also the style used in other of our projects, e.g. Tobira and the editor. I would have loved to amend the commit that introduced the single-quotes rule, but that has already been on master for some time. So we have to live with the somewhat noisy git history here.
|
Looks good. |
narickmann
approved these changes
Jan 4, 2023
|
As this rule is only about JSX, it does not check any quotations marks anywhere else. But yes, it is a good point and might want to add another rule for other kinds of quotes. I'd like to talk in our team meetings about this. |
|
This is already merged now, but why is this closer to HTML? HTML allows both single and double quotes and I often use single quotes in HTML. |
|
Oh really? 👀 Today I learned. Crazy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is closer to normal HTML and is also the style used in other of our projects, e.g. Tobira and the editor.
I would have loved to amend the commit that introduced the single-quotes rule, but that has already been on master for some time. So we have to live with the somewhat noisy git history here.