Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Videos/Wiedergabelisten übertragen" is not working #879

Closed
kai-wng-uos opened this issue Jan 10, 2024 · 14 comments · Fixed by #931
Closed

"Videos/Wiedergabelisten übertragen" is not working #879

kai-wng-uos opened this issue Jan 10, 2024 · 14 comments · Fixed by #931
Assignees
Labels
v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x

Comments

@kai-wng-uos
Copy link
Collaborator

kai-wng-uos commented Jan 10, 2024

Several issues with this feature:

  • the way the button is worded, it suggests that you can choose specific videos and/or playlists to transfer between courses. The dialog then suggests all contents of the course are being transferred. I would suggest changing the button to "Kursinhalte übertragen"
  • when you then try to transfer all contents (as the dialog claims) to a different course, all playlists and the videos in those playlists are transferred to the chosen course. However, the videos from the "Kurswiedergabeliste" are not transferred.
  • Instead of the videos from the start course's "Kurswiedergabeliste" being transferred to the destination course's "Kurswiedergabeliste", videos from the other transferred playlists are listed there.
  • I have not yet figured out why certain videos from the playlists are shown in the "Kurswiedergabeliste" but other are not
@kai-wng-uos kai-wng-uos added the v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x label Jan 10, 2024
@kai-wng-uos
Copy link
Collaborator Author

kai-wng-uos commented Jan 10, 2024

additionally to this, the playlists are laso not copied to the destination course, but linked, meaning that every change to the playlist in one course will effect this playlist in all courses it has been transferred to. This relates to #797. On the other hand, deleting a playlist from a course (no matter if it's the start or destination course) doesn't affect the playlists in transferred courses --> inconsistent.

@kai-wng-uos
Copy link
Collaborator Author

Also, there are always two videos being added to the course playlist of the destination course. These videos were not part of any playlists in the original course, yet they crop up in the course playlist.

@kai-wng-uos
Copy link
Collaborator Author

Further testing shows that the migration between courses seems to be working with all playlists except the course playlist. Here, the migration is very inconsistent. Sometimes it works fine, sometimes only certain videos are transferred, sometimes none. @tgloeggl could this be a test system issue?

@dennis531 dennis531 self-assigned this Jan 22, 2024
@dennis531
Copy link
Collaborator

I think most of the problems could be solved by #893. Now the "Videos/Wiedergabelisten übertragen" action copies all playlists including the "Kurswiedergabeliste" playlist to the destination course.

@dennis531
Copy link
Collaborator

when you then try to transfer all contents (as the dialog claims) to a different course, all playlists and the videos in those playlists are transferred to the chosen course. However, the videos from the "Kurswiedergabeliste" are not transferred.

Should be solved by #893.

Instead of the videos from the start course's "Kurswiedergabeliste" being transferred to the destination course's "Kurswiedergabeliste", videos from the other transferred playlists are listed there.

Probably caused by #901. Shoud be solved by #906.

I have not yet figured out why certain videos from the playlists are shown in the "Kurswiedergabeliste" but other are not

This problem could be related to #901 or is/was caused by false or confusing video permissions.

additionally to this, the playlists are laso not copied to the destination course, but linked, meaning that every change to the playlist in one course will effect this playlist in all courses it has been transferred to. This relates to #797. On the other hand, deleting a playlist from a course (no matter if it's the start or destination course) doesn't affect the playlists in transferred courses --> inconsistent.

I hope it is solved by #893

dennis531 pushed a commit to dennis531/studip-opencast-plugin that referenced this issue Jan 23, 2024
@dennis531
Copy link
Collaborator

After #906 is merged, this function should be tested again.

tgloeggl pushed a commit that referenced this issue Jan 25, 2024
Co-authored-by: Dennis Benz <dennis.benz@uos.de>
@kai-wng-uos
Copy link
Collaborator Author

currently not working at all...

Aufzeichnung.2024-01-31.100125.mp4

@kai-wng-uos kai-wng-uos reopened this Jan 31, 2024
@kai-wng-uos
Copy link
Collaborator Author

turns out it is working, but the transferred data only appears after you've (manually) created a playlist. Very confusing. Either add a warning that says something like "um Inhalte in diesen Kurs zu übertragen, müssen Sie zunächst eine Standardplaylist in dem Kurs anlegen", or just make the origin course's default playlist the default playlist for the destination course.

@dennis531
Copy link
Collaborator

Possible solution:

  • If no default playlist is set in target course, set default playlist of source course as default
  • Otherwise don't change default course

Should match the second solution in #879 (comment).

dennis531 pushed a commit to dennis531/studip-opencast-plugin that referenced this issue Feb 2, 2024
tgloeggl pushed a commit that referenced this issue Feb 7, 2024
 (#931)

Co-authored-by: Dennis Benz <dennis.benz@uos.de>
@kai-wng-uos
Copy link
Collaborator Author

The initial Problem is solved, however, it still has a few problems:

  • To perform the transfer, the OC Plugin has to already be activated. The more elegant solution would be that the transfer automatically activates the plugin in the target course
  • the playlists are displayed in a different order than in the source course

@kai-wng-uos kai-wng-uos reopened this Feb 12, 2024
@dennis531
Copy link
Collaborator

  • To perform the transfer, the OC Plugin has to already be activated. The more elegant solution would be that the transfer automatically activates the plugin in the target course

I am rather against automatically activating the plugin. I think the user should have control over the activation of the plugin in the course. By activating the plugin manually, lecturers can keep better track of which courses are activated, instead of enabling it magically in the background. In addition, we would need to provide some kind of notification when the plugin is activated in the background.

the playlists are displayed in a different order than in the source course

I will fix this problem.

@dennis531
Copy link
Collaborator

dennis531 commented Feb 14, 2024

Playlists in the course are currently sorted in ascending order by their creation date. The problem occurs because the copied playlists do not copy the creation date, but set the copy date as creation date instead. I tried to copy the playlists sorted by creation date. This approach does not work, as all copied playlists ended with the same creation dates, at least in my test system. So this problem is not trivial to solve as long as we do not offer a sorting option for the playlists in the course. It would be possible to offset the creation dates, e.g. by one second. But that would lead to messy hacks in the code.

In conclusion, it would be best to solve this problem with the planned sorting function of playlists in courses to avoid ugly code.

@kai-wng-uos
Copy link
Collaborator Author

  • To perform the transfer, the OC Plugin has to already be activated. The more elegant solution would be that the transfer automatically activates the plugin in the target course

I am rather against automatically activating the plugin. I think the user should have control over the activation of the plugin in the course. By activating the plugin manually, lecturers can keep better track of which courses are activated, instead of enabling it magically in the background. In addition, we would need to provide some kind of notification when the plugin is activated in the background.

I understand the approach to make actions as transparent as possible. However, I also think in attempting to copy Opencast contents from one course to the next it is clear that a lecturer wants to also activate the plugin, so why make them leave the copying dialog, go to the target course manually, activate the pluging, then return to the original course and start the copying action. To me, this seems unnecessarily tedious. Maybe a notification as to the automatic activation would be a good middle ground?

@dennis531
Copy link
Collaborator

I created new issues for the mentioned problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x
Projects
Status: Testing
Development

Successfully merging a pull request may close this issue.

2 participants