Tests: Add fixes and refactorings #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis531
added
type:bug
v:3
The cronjob will be executed in the docker container if no studip directory exists on the host.
dennis531
force-pushed
the
fix-video-tests
branch
from
1eddfd5 to
3191024
Compare
dennis531
changed the title
dennis531
force-pushed
the
fix-video-tests
branch
from
ae05388 to
a418522
Compare
tgloeggl
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem where the test tries to run the cronjob on the host instead of in the container. The
runCronjobfunction now checks whether the Stud.IP cli command exists and executes the cronjob based on this either on the host or in the container.