Add option preventing deletion of unrelated events #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rillke
changed the title
Rillke
force-pushed
the
rr/optionManageAllOcEvents
branch
from
ecf3bf7 to
f42ad89
Compare
Rillke
changed the title
Rillke
changed the title
|
I noticed an edge case which may cause to deletion of events that are perfectly fine if they are scheduled in the moment the cronjob runs. This is now fixed, too. |
Rillke
force-pushed
the
rr/optionManageAllOcEvents
branch
from
f42ad89 to
6012c0f
Compare
Rillke
changed the title
- It's unexpected that SHOW_TOS has ruled whether scheduled events not created by Stud.IP would be deleted or not. - Stud.IP should not always delete events scheduled in Opencast by other software, e.g. the Opencast admin interface. - By default, the new option to delete events not created by Stud.IP is *turned off*. - Always delete events which have been created if the course date can't be found in Stud.IP anymore (i.e. the date had been ereased). - Determine events to be deleted more safely: First ask Opencast so it can't return events scheduled while the cronjob was running and queried the Stud.IP DB for known schedule.
Rillke
force-pushed
the
rr/optionManageAllOcEvents
branch
from
6012c0f to
c8e7cfe
Compare
|
|
@tgloeggl If you are ready to merge this, please let me know, or just rename the DB update after merge :) It's in our production for a while and produces nice logs on every run (and only deletes those events it should). |
|
Das sieht gut aus, danke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
events not created by Stud.IP would be deleted or not.
by other software, e.g. the Opencast admin interface.
Stud.IP is turned off.
course date can't be found in Stud.IP anymore (i.e. the date had
been ereased).