Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GET parameter to specify a timestamp for a video (e.g. t=3m12s) #191

Closed
LukasKalbertodt opened this issue Mar 1, 2021 · 2 comments · Fixed by #943
Closed

Add GET parameter to specify a timestamp for a video (e.g. t=3m12s) #191

LukasKalbertodt opened this issue Mar 1, 2021 · 2 comments · Fixed by #943
Assignees
@owi92
Labels
area:frontend Everything frontend related good-starter Issues (somewhat) suited for devs new to Tobira kind:new-feature A new feature priority:low Low priority

Comments

@LukasKalbertodt
Copy link
Member

Basically like YouTube does, we want that as well. Loading such a page would immediately jump to the specified timestamp in the video. I would try to not "naturally generated" these links though. Instead, you would only get such a link when explicitly using a UI element to "set a time" or if you manually edit the link. That's different from YouTube where sometimes (e.g. when you started a video before) the link already contains the timestamp. That leads to me always asking friends "is the timestamp intentional" when they send me videos with timestamp in it. And roughly half of the time it isn't!
@LukasKalbertodt LukasKalbertodt added area:frontend Everything frontend related kind:new-feature A new feature priority:low Low priority labels Mar 1, 2021
@LukasKalbertodt LukasKalbertodt moved this to Todo in Tobira Nov 23, 2022
@LukasKalbertodt LukasKalbertodt added the good-starter Issues (somewhat) suited for devs new to Tobira label Nov 24, 2022
@JulianKniephoff
Copy link
Member

Would this only be supported on the video page or do we wanna be clever about video blocks as well? 🤔

@LukasKalbertodt
Copy link
Member Author

Video Pages only for now? I can't think of a nice way how to make it work within realm pages. Adding a second video block then breaks stuff? Naaah

This was referenced Jan 19, 2023
Closed
Closed
@owi92 owi92 mentioned this issue Sep 20, 2023
Merged
@LukasKalbertodt LukasKalbertodt moved this from Todo to In Review 👀 in Tobira Sep 25, 2023
LukasKalbertodt added a commit that referenced this issue Sep 26, 2023
@LukasKalbertodt
Add "start at:" option to share menu (#943)
6d6e9ed 
Closes #191

- This adds a "Start at: {time}" timepicker to the direct link on the
`Video details` page and both share options of the video page's share
menu.
- Picking a time will append said time as a search query to the shared
link.
- The linked video will start at the chosen time.
- Users can also manually add a time to a link in their browser by
appending `?t=2h2m20s` (or any other combination of hours, minutes and
seconds like `?t=2m` or `?t=1h20s` or `?t=20s` etc). You can try it out
with https://pr943.tobira.opencast.org/v/GjDqXFlukkH?t=20s (or any other
video).

- There is unfortunately one visual issue with the time picker in
chrome, where the rightmost number is slightly cut off. I don't know
what causes this yet.
<img width="246" alt="Bildschirmfoto 2023-09-20 um 23 11 22"
src="https://github.com/elan-ev/tobira/assets/94838646/5e2c515e-71aa-44bf-ab01-2ff59fac06a1">

- As always, visuals and wording (and I also the places where this is
included) are open for discussion and feedback is appreciated.
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✔️ in Tobira Sep 26, 2023
@oellers oellers mentioned this issue Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owi92 owi92

Labels
area:frontend Everything frontend related good-starter Issues (somewhat) suited for devs new to Tobira kind:new-feature A new feature priority:low Low priority
Projects
Tobira
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "start at:" option to share menu owi92/tobira
3 participants
@JulianKniephoff @LukasKalbertodt @owi92