Searchbar via Mobile: Input Keyboard does not disappear when displaying search results #470
Labels
Comments
LukasKalbertodt
added
area:frontend
owi92
added a commit
that referenced
this issue
Nov 18, 2024
This PR improves the whole main search page in various ways. Most important points: - Thumbnails are now on the left (I know a certain someone who will very much welcome this change 😉 ) - The three different kinds of results were designed to be visually easier to distinguish. - Videos and series also show the realm path (if there is only one host realm) - The date is added to videos - The matching portion in search results is highlighted, to show the user immediately why a result appears. - Note: This does not work for "creators" yet, due to a limitation in the search index we use. We have to wait for an upstream fix. - Note: metadata like description and title are truncated if too long. If the match would appear in the parts that are cut off, it would be still confusing for the user. Therefore, the metadata is truncated/cut in such a way that the part with the match is shown. (Example: first result for search "hadron myers") This PR is a draft because I still want to do this: - [x] Talk to our designer - [x] Squash two mobile keyboard bugs - [x] ~~Potentially change the "realm" icon~~ -> No - [x] Fix bug where the last input on the search field can sometimes be ignored - [x] ~~Make highlight color stronger~~ -> See some comments below In a separate, follow-up PR I still plan on doing these search-related things: - Use Meili federated search (improves ranking, potentially speed, and prepares pagination) - Improve ranking to make series appear before videos of that series with title = series title when searching for series title - Potentially merge series and page results when the page is a "series-only-page" for that series - Maybe: with multiple host realms, if only one exists that derives its name from the series/event, use it for breadcrumbs & link. - Finally decide about #500 Finally, filtering is still missing, which deserves a PR on its own. --- Feedback is very welcome! Fixes #470 Fixes #1066 Fixes #1065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: