Embedding videos using Opencast IDs #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
LukasKalbertodt
requested changes
Jun 3, 2024
There was a problem hiding this comment.
That feature makes sense to us!
Looking at the code: could you try to avoid the duplication of code in the GraphQL queries? You can use a fragment for that. Check routes/Video.tsx and its eventFragment for orientation. I think it should be straight forward? But if you encounter weird problems, feel free to reach out.
Previously, embedding videos was only possible using the Tobira ID. This change introduces the ability to embed videos with Opencast IDs using the same embedding format (`/~embed/!v/:<opencast-id>`). This enhancement improves flexibility and consistency in video embedding options.
geichelberger
force-pushed
the
embed-opencast-id
branch
from
e4804bb
to
9cda08f
Compare
github-actions
bot
removed
the
status:conflicts
|
I did not think about the fragment feature; I introduced a fragment and rebased the PR onto the current master. |
LukasKalbertodt
requested changes
Jun 3, 2024
- Remove duplicate embed player code - Make useFragment typesafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, embedding videos was only possible using the Tobira ID. This change introduces the ability to embed videos with Opencast IDs using the same embedding format (
/~embed/!v/:<opencast-id>). This enhancement improves flexibility and consistency in video embedding options.