Fix overflowing videos #1183
Merged
Fix overflowing videos #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The video container width is set to `unset` when there is enough space for the control elements. I know this had a good-ish reason, I just don't remember it. On that note, I should start writing better commit messages, or at least try to explain things like that. So anyway, this unset width can lead to situations were videos with weird aspect ratios like 15/4 or sth would overflow on smaller (but larger than mobile) screens. To fix that without removing or complicating the `unset` rule, this commit introduced a `maxWidth` of 100%. BUT, that also needs to be overwritten on mobile screens to preserve current sizing behaviour on these.
LukasKalbertodt
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The video container width is set to
unsetwhen there is enough space for the control elements. I know this had a good-ish reason, I just don't remember it.On that note, I should start writing better commit messages, or at least try to explain things like that so I can later remember it.
So anyway, this unset width can lead to situations were videos with weird aspect ratios like 15/4 or sth would overflow on smaller (but larger than mobile) screens. To fix that without removing or further complicating the
unsetrule, this commit introduced amaxWidthof 100%. BUT that also needs to be overwritten on mobile screens to preserve current sizing behaviour on these.Closes #1173