Skip to content

Commit

Permalink
fix: dont use package version for image tag (#214)
Browse files Browse the repository at this point in the history
* fix: dont use package version for image tag

its error prone. if we forget to update the version we overright an existing tag.

we already have timestamp based tags. just use those.

fixes: elastic-ipfs/elastic-ipfs#29

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>

* 0.19.3

---------

Signed-off-by: Oli Evans <oli@protocol.ai>
  • Loading branch information
olizilla committed Jun 2, 2023
1 parent fb7ef1c commit 9c2dab0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/shared-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ on:
required: false
default: true
outputs:
package_version:
description: package_version
value: ${{ jobs.build.outputs.package_version }}
build_date:
description: build_date
value: ${{ jobs.build.outputs.build_date }}
Expand Down Expand Up @@ -70,7 +67,6 @@ jobs:
push: ${{ inputs.docker_push }}
context: .
tags: |
${{ env.REGISTRY }}/${{ env.IMAGE_REPOSITORY }}/app:${{ env.PACKAGE_VERSION }}-${{ inputs.docker_image_version_suffix_label }}
${{ env.REGISTRY }}/${{ env.IMAGE_REPOSITORY }}/app:${{ env.BUILD_DATE }}-${{ inputs.docker_image_version_suffix_label }}
${{ env.REGISTRY }}/${{ env.IMAGE_REPOSITORY }}/app:${{ inputs.docker_image_version_suffix_label }}
labels: |
Expand All @@ -83,13 +79,11 @@ jobs:
push: ${{ inputs.docker_push }}
context: .
tags: |
${{ env.REGISTRY }}/${{ env.IMAGE_REPOSITORY }}/app:${{ env.PACKAGE_VERSION }}
${{ env.REGISTRY }}/${{ env.IMAGE_REPOSITORY }}/app:${{ env.BUILD_DATE }}
${{ env.REGISTRY }}/${{ env.IMAGE_REPOSITORY }}/app:latest
labels: |
org.opencontainers.image.source=https://github.com/${{ github.repository }}
- name: Set output variables
id: setOutput
run: |
echo "package_version=${{ env.PACKAGE_VERSION }}" >> $GITHUB_OUTPUT
echo "build_date=${{ env.BUILD_DATE }}" >> $GITHUB_OUTPUT
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bitswap-peer",
"version": "0.19.2",
"version": "0.19.3",
"description": "Elastic IPFS BitSwap Peer",
"homepage": "https://github.com/elastic-ipfs/bitswap-peer",
"license": "(Apache-2.0 AND MIT)",
Expand Down

0 comments on commit 9c2dab0

Please sign in to comment.