fix: re-enable yamux #205
Merged
fix: re-enable yamux #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
pushed a commit
to storacha/dagula
that referenced
this pull request
Apr 26, 2023
Note: elastic-ipfs/bitswap-peer#205 needs to merge before yamux will be used with the default peer.
alanshaw
pushed a commit
to storacha/dagula
that referenced
this pull request
May 18, 2023
Note: elastic-ipfs/bitswap-peer#205 needs to merge before yamux will be used with the default peer.
alanshaw
pushed a commit
to storacha/dagula
that referenced
this pull request
May 18, 2023
Note: elastic-ipfs/bitswap-peer#205 needs to merge before yamux will be used with the default peer.
|
There's been some discussion about removing support for mplex in Kubo/boxo, epfs was mentioned: https://filecoinproject.slack.com/archives/C04M8232QRW/p1691163791844409 by @Jorropo Is this PR still needed? |
|
I have tested connecting to elastic.dag.house with just yamux and it works so I don't guess so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables yamux in E-IPFS. Some historical context:
Please note that deploying this needs attention and we should monitor and perform canary release.
Closes elastic-ipfs/elastic-ipfs#25