Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove container_metadata_discovery from tests #1497

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Remove container_metadata_discovery from tests #1497

merged 1 commit into from
Jul 26, 2023

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Jul 26, 2023

Removing the newly introduced tests for container_metadata_discovery.json until changes from elastic/apm#807 are implemented.

@simitt simitt requested a review from a team as a code owner July 26, 2023 05:48
axw
axw approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there an issue in this repo which we can add a reminder to?

@simitt
Copy link
Contributor Author

simitt commented Jul 26, 2023

There is now #1498 ;)

@simitt simitt merged commit ded2651 into elastic:main Jul 26, 2023
8 checks passed
kruskall pushed a commit to kruskall/apm-agent-go that referenced this pull request Jul 26, 2023
@simitt @kruskall
Remove container_metadata_discovery from tests (elastic#1497)
863c772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
agent-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simitt @axw