Add support for instrumenting AWS SNS #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartnelson3
commented
Apr 15, 2021
stuartnelson3
commented
Apr 15, 2021
|
|
||
| func getTopicName(req *request.Request) string { | ||
| // TODO: PhoneNumber is the third possibility, but I'm guessing we | ||
| // don't want to store that for customers? |
There was a problem hiding this comment.
I figure we don't want to store something with such explosive cardinality, but made a note in case you know anything else.
@AlexanderWert do you know?
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
axw
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few questions called out in the code below, but other than that it does what it says on the tin.
closes #882