Skip to content

Commit

Permalink
Fix failing test
Browse files Browse the repository at this point in the history
  • Loading branch information
Mistborn94 committed Jan 8, 2025
1 parent fac3455 commit e30d4ae
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,10 @@ protected ErrorCaptureImpl getFirstError() {
}

static TransactionImpl checkTransaction(TransactionImpl transaction, String expectedName, String expectedMethod, int expectedStatus) {
return checkTransaction(transaction, expectedName, expectedMethod, expectedStatus, "5.3.30");
}

static TransactionImpl checkTransaction(TransactionImpl transaction, String expectedName, String expectedMethod, int expectedStatus, String expectedFrameworkVersion) {
assertThat(transaction.getType()).isEqualTo("request");
assertThat(transaction.getNameAsString()).isEqualTo(expectedName);

Expand All @@ -468,7 +472,7 @@ static TransactionImpl checkTransaction(TransactionImpl transaction, String expe
.isEqualTo("Spring Webflux");

assertThat(transaction.getFrameworkVersion())
.isEqualTo("5.3.30");
.isEqualTo(expectedFrameworkVersion);

return transaction;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void shouldOnlyCreateOneTransaction() throws InterruptedException {
TransactionImpl transaction = reporter.getFirstTransaction(200);

// transaction naming should be set by webflux instrumentation
AbstractServerInstrumentationTest.checkTransaction(transaction, "GET /functional/with-parameters/{id}", "GET", 200);
AbstractServerInstrumentationTest.checkTransaction(transaction, "GET /functional/with-parameters/{id}", "GET", 200, "6.2.0");

// transaction HTTP part should be provided by servlet instrumentation
AbstractServerInstrumentationTest.checkUrl(client, transaction, "/with-parameters/42");
Expand Down

0 comments on commit e30d4ae

Please sign in to comment.