Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero garbage JDBC tracing #35

Closed
felixbarny opened this issue Mar 22, 2018 · 1 comment · Fixed by #84
Closed

Zero garbage JDBC tracing #35

felixbarny opened this issue Mar 22, 2018 · 1 comment · Fixed by #84

Comments

@felixbarny
Copy link
Member

felixbarny commented Mar 22, 2018 •
edited by alvarolobato
Loading

P6spy allocates objects on each query:

https://github.com/p6spy/p6spy/blob/f9f852e895419a8adcda590618aec4ae47513cfe/src/main/java/com/p6spy/engine/wrapper/PreparedStatementWrapper.java#L59-L64

So investigate if p6spy could be easily modified to allow for object pooling or if we should rather implement our own JDBC wrapper. P6spy has an extensive test suite for all sorts of databases and application servers so it would be nice to leverage this.
@felixbarny felixbarny added this to the Beta milestone Mar 22, 2018
@felixbarny
Copy link
Member Author

See also p6spy/p6spy#436

This was referenced Apr 17, 2018
Closed
Closed
felixbarny added a commit to felixbarny/apm-agent-java that referenced this issue May 14, 2018
@felixbarny
JDBC instrumentation
a1f8ece 
closes elastic#35

Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
@felixbarny felixbarny mentioned this issue May 14, 2018
Merged
felixbarny added a commit to felixbarny/apm-agent-java that referenced this issue May 15, 2018
@felixbarny
JDBC instrumentation
883d650 
closes elastic#35

Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
felixbarny added a commit that referenced this issue May 15, 2018
@felixbarny
JDBC instrumentation (#84)
02da44a 
closes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JDBC instrumentation felixbarny/apm-agent-java
2 participants
@felixbarny @alvarolobato