migrate to indy apm-error-logging-plugin #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
37 tasks
felixbarny
reviewed
Aug 31, 2020
| return Boolean.FALSE; | ||
| } | ||
| }; | ||
| public static final GlobalThreadLocal<Boolean> nestedThreadLocal = GlobalThreadLocal.get(AbstractLoggerErrorCapturingInstrumentation.class, "nested", Boolean.FALSE); |
There was a problem hiding this comment.
Can be simplified with co.elastic.apm.agent.sdk.state.CallDepth. See co.elastic.apm.agent.servlet.RequestStreamRecordingInstrumentation.GetInputStreamAdvice as an example.
When using it, make sure to add onThrowable = Throwable.class to OnMethodExit. See also the Javadocs of co.elastic.apm.agent.sdk.state.CallDepth#decrement for more details.
There was a problem hiding this comment.
replaced with CallDepth
felixbarny
reviewed
Aug 31, 2020
Comment on lines
70
to
72
| if (callDepth.isNestedCallAndDecrement()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Can be simplified as there's already a if (errorCaptureObj instanceof ErrorCapture) check afterwards. That check is only true if the error object is not null.
Suggested change
| if (callDepth.isNestedCallAndDecrement()) { | |
| return; | |
| } | |
| callDepth.decrement(); |
felixbarny
approved these changes
Aug 31, 2020
SylvainJuge
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer #1337