Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to indy jaxrs plugin #1374

Merged
merged 8 commits into from
Apr 14, 2021

Conversation

videnkz
Copy link
Contributor

@videnkz videnkz commented Sep 1, 2020

refer #1337
hello, useAnnotationValueForTransactionName returns false during the test. But when JaxRsTransactionNameInstrumentation construct useAnnotationValueForTransactionName mocked with true value:

            if (useAnnotationValueForTransactionName) {
                if (pathAnnotationValue != null) {
                    transactionName = pathAnnotationValue;
                }
            }

@videnkz videnkz changed the title migrate to indy jaxres plugin migrate to indy jaxrs plugin Sep 1, 2020
@apmmachine
Copy link
Contributor

apmmachine commented Sep 1, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Felix Barnsteiner

  • Start Time: 2021-04-14T10:13:43.631+0000

  • Duration: 54 min 19 sec

  • Commit: dce0ebc

Test stats 🧪

Test Results
Failed 0
Passed 1984
Skipped 19
Total 2003

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1984
Skipped 19
Total 2003

@felixbarny
Copy link
Member

You'll have to use GlobalVariables for useAnnotationValueForTransactionName, as the JaxRsTransactionNameInstrumentation class is loaded twice: once from the system class loader and once from the IndyPluginClassLoader. The constructor will only be called for the class loaded by the system class loader.
The other class will use the initial value of false.

@videnkz
Copy link
Contributor Author

videnkz commented Sep 1, 2020

GlobalVariables

Thanks

@SylvainJuge SylvainJuge mentioned this pull request Sep 15, 2020
37 tasks
@videnkz
Copy link
Contributor Author

videnkz commented Sep 18, 2020

@SylvainJuge , @felixbarny please review this PR
Thanks

@SylvainJuge SylvainJuge added the technical-debt Technical debt label Mar 1, 2021
@SylvainJuge
Copy link
Member

There is an unexpected java.lang.IllegalStateException: Cannot resolve type description for co.elastic.apm.agent.httpclient.AbstractHttpClientInstrumentationTest in the tests, @felixbarny can I let you handle this ?

@felixbarny felixbarny merged commit 0c69097 into elastic:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants