-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced emdedded RedisServer with testcontainers. #2221
Replaced emdedded RedisServer with testcontainers. #2221
Conversation
…est classes(Lettuce*Test) - junit4 has been replaced with version5
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Hi @cachedout , please check this. |
run elasticsearch-ci/docs |
@felixbarny do we need to test a specific Redis version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the tests extending AbstractRedisInstrumentationTest
so that they end with IT
(integration test). This makes them not run when doing a mvn test
, only a mvn verify
.
I don't think we need to test against a specific Redis server version.
…ionTest from Test to IT.
Done |
/test |
run elasticsearch-ci/docs |
closes #2175
What does this PR do?
Checklist