[DOCS] Clarify the frequency of config polling #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackshirazi
reviewed
Sep 16, 2024
lucabelluccini
commented
Sep 16, 2024
JonasKunz
reviewed
Sep 17, 2024
There was a problem hiding this comment.
LGTM, if @jackshirazi agrees I'll take care of this PR.
The markdown file is actually auto-generated, we'll need to add the paragraph in the Java sources instead.
|
@JonasKunz yes please |
jackshirazi
approved these changes
Sep 17, 2024
|
This PR was merged on the wrong branch (1.x instead of main). We'll have to reopen it on the correct branch, otherwise it causes conflicts during release. I had to revert this PR on 1.x to proceed with the release. |
JonasKunz
added a commit
to JonasKunz/apm-agent-java
that referenced
this pull request
Nov 18, 2024
This reverts commit 0ab2a3a.
JonasKunz
added a commit
to JonasKunz/apm-agent-java
that referenced
this pull request
Nov 21, 2024
--------- Co-authored-by: Jonas Kunz <jonas.kunz@elastic.co>
JonasKunz
added a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clarify the frequency of config polling
apm-agent-java/apm-agent-core/src/main/java/co/elastic/apm/agent/configuration/ApmServerConfigurationSource.java
Line 59 in 9a12b98