Fix noop handling for Transactions and Spans #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds Transaction.noop flag - noop Transactions don't get reported - noop Transactions are not a singleton, as this leads or threading issues - startSpan returns null if current transaction is null or noop - public api never returns null span but returns noop span fixes elastic#71 Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
============================================
+ Coverage 75.77% 76.08% +0.31%
+ Complexity 723 721 -2
============================================
Files 78 78
Lines 2621 2622 +1
Branches 233 237 +4
============================================
+ Hits 1986 1995 +9
+ Misses 497 495 -2
+ Partials 138 132 -6
Continue to review full report at Codecov.
|
This was referenced Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #71
Signed-off-by: Felix Barnsteiner felix.barnsteiner@elastic.co