Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument servlet invocations with BCI #80

Merged
merged 5 commits into from
May 12, 2018

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented May 9, 2018

Related #62

@alvarolobato alvarolobato modified the milestones: 1.0, Beta May 9, 2018
Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
@felixbarny felixbarny force-pushed the servlet-instrumentation branch from 034135d to 4cdea91 Compare May 9, 2018 10:54
@codecov-io
Copy link

codecov-io commented May 9, 2018

Codecov Report

Merging #80 into master will decrease coverage by 1.01%.
The diff coverage is 72.8%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #80      +/-   ##
============================================
- Coverage     76.41%   75.39%   -1.02%     
- Complexity      749      777      +28     
============================================
  Files            83       86       +3     
  Lines          2730     2869     +139     
  Branches        245      270      +25     
============================================
+ Hits           2086     2163      +77     
- Misses          510      568      +58     
- Partials        134      138       +4
Impacted Files Coverage Δ Complexity Δ
.../co/elastic/apm/bci/ElasticApmInstrumentation.java 100% <100%> (ø) 3 <3> (?)
...ava/co/elastic/apm/web/SanitizingWebProcessor.java 90.47% <100%> (-2.12%) 10 <3> (-3)
...a/co/elastic/apm/report/ReportingEventHandler.java 92.59% <100%> (-7.41%) 9 <5> (-1)
...ain/java/co/elastic/apm/impl/context/Response.java 96% <100%> (ø) 13 <0> (ø) ⬇️
...lastic/apm/report/serialize/DslJsonSerializer.java 84.61% <100%> (-0.15%) 78 <1> (ø)
...lastic/apm/servlet/FilterChainInstrumentation.java 30% <30%> (ø) 5 <5> (?)
...co/elastic/apm/servlet/ServletInstrumentation.java 32.43% <32.43%> (ø) 5 <5> (?)
...a/co/elastic/apm/impl/ElasticApmTracerBuilder.java 77.55% <71.42%> (-2%) 11 <1> (ø)
...rc/main/java/co/elastic/apm/servlet/ApmFilter.java 66.66% <74.19%> (-10.06%) 5 <4> (-23)
.../main/java/co/elastic/apm/bci/ElasticApmAgent.java 80.88% <81.48%> (-6.3%) 7 <5> (+3)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f8d8e...877c074. Read the comment docs.

It is now based on two Lists which allow to avoid iterator allocations

Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
Fixes class loader issues

Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
@felixbarny felixbarny merged commit a3ba319 into elastic:master May 12, 2018
@felixbarny felixbarny deleted the servlet-instrumentation branch May 12, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants