Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable certain instrumentations #95

Merged
merged 1 commit into from
May 29, 2018

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented May 29, 2018

closes #87

closes elastic#87

Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
@codecov-io
Copy link

Codecov Report

Merging #95 into master will increase coverage by 0.04%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
+ Coverage      75.9%   75.94%   +0.04%     
- Complexity      842      856      +14     
============================================
  Files            92       92              
  Lines          3025     3043      +18     
  Branches        263      264       +1     
============================================
+ Hits           2296     2311      +15     
- Misses          591      593       +2     
- Partials        138      139       +1
Impacted Files Coverage Δ Complexity Δ
.../co/elastic/apm/bci/ElasticApmInstrumentation.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...tic/apm/jdbc/PreparedStatementInstrumentation.java 83.33% <100%> (+0.98%) 7 <1> (+1) ⬆️
.../co/elastic/apm/jdbc/StatementInstrumentation.java 88.23% <100%> (+0.73%) 8 <1> (+1) ⬆️
...g/webmvc/SpringTransactionNameInstrumentation.java 59.37% <100%> (+1.31%) 6 <1> (+1) ⬆️
...co/elastic/apm/plugin/api/SpanInstrumentation.java 68.42% <100%> (+1.75%) 5 <1> (+1) ⬆️
...tic/apm/plugin/api/TransactionInstrumentation.java 62.96% <100%> (+1.42%) 5 <1> (+1) ⬆️
...lastic/apm/servlet/FilterChainInstrumentation.java 28.26% <100%> (+1.59%) 6 <1> (+1) ⬆️
...co/elastic/apm/jdbc/ConnectionInstrumentation.java 94.11% <100%> (+0.36%) 7 <1> (+1) ⬆️
...c/apm/plugin/api/ElasticApmApiInstrumentation.java 53.12% <100%> (+1.51%) 5 <1> (+1) ⬆️
...co/elastic/apm/servlet/ServletInstrumentation.java 33.33% <100%> (+1.75%) 6 <1> (+1) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53611b3...04e07f7. Read the comment docs.

@felixbarny felixbarny merged commit 4b9460b into elastic:master May 29, 2018
@felixbarny felixbarny deleted the disabled-instrumentations branch May 29, 2018 13:22
@v1v v1v mentioned this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to disable certain instrumentations
3 participants