fix: obviously sync spans are not sent as sync

Fixes #1878
elastic · Nov 17, 2020 · b897c81 · b897c81
1 parent 289ec42
commit b897c81
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/lib/instrumentation/async-hooks.js b/lib/instrumentation/async-hooks.js
@@ -71,6 +71,9 @@ module.exports = function (ins) {
     // type, which will init for each scheduled timer.
     if (type === 'TIMERWRAP') return
 
+    // XXX
+    // debug(`${type}(${asyncId}): trigger: ${triggerAsyncId}`);
+
     const transaction = ins.currentTransaction
     if (!transaction) return
 
@@ -91,6 +94,7 @@ module.exports = function (ins) {
   function before (asyncId) {
     const span = activeSpans.get(asyncId)
     if (span) {
+      debug(`setting span.sync=false on span.id==${span.id} with span.ended==${span.ended}`)
       span.sync = false
     }
     const transaction = span ? span.transaction : activeTransactions.get(asyncId)
@@ -116,3 +120,9 @@ module.exports = function (ins) {
     activeSpans.delete(asyncId)
   }
 }
+
+var fs = require('fs');
+function debug(msg) {
+  fs.writeSync(process.stdout.fd,
+    `[executionAsyncId=${asyncHooks.executionAsyncId()}] ${msg}\n`);
+}
diff --git a/test/instrumentation/async-hooks.js b/test/instrumentation/async-hooks.js
@@ -135,6 +135,22 @@ test('sync/async tracking', function (t) {
   })
 })
 
+test.only('sync/async tracking 2', function (t) {
+  var trans = agent.startTransaction()
+
+  var span = agent.startSpan()
+  t.strictEqual(span.sync, true, 'span.sync=true immediately after creation')
+
+  span.end()
+  t.strictEqual(span.sync, true, 'span.sync=true immediately after end')
+
+  setImmediate(() => {
+    t.strictEqual(span.sync, true,
+      'span.sync=true later after having ended sync')
+    t.end()
+  })
+})
+
 function twice (fn) {
   setImmediate(fn)
   setImmediate(fn)