Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test coverage for getModule in parsers.js #1918

Closed
trentm opened this issue Dec 16, 2020 · 0 comments · Fixed by #1920
Closed

improve test coverage for getModule in parsers.js #1918

trentm opened this issue Dec 16, 2020 · 0 comments · Fixed by #1920
Assignees
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Dec 16, 2020

Following up from a review comment on #1877, it would be good to add some test coverage of getModule in lib/parsers.js. Currently there is just one test case check of error.exception.module (which comes from getModule()) in "test/instrumentation/modules/@elastic/elasticsearch.js".

@trentm trentm self-assigned this Dec 16, 2020
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Dec 16, 2020
trentm added a commit that referenced this issue Dec 18, 2020
Also refactor lib/parsers.js slightly. No functional change.

Fixes: #1918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant