Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Rename Active Test Files to .test. #2137

Closed
astorm opened this issue Jun 30, 2021 · 1 comment
Closed

Proposal: Rename Active Test Files to .test. #2137

astorm opened this issue Jun 30, 2021 · 1 comment
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@astorm
Copy link
Contributor

astorm commented Jun 30, 2021

As preparation for a possible move from tape to tap, we should rename any test file that contains actual tests (but leave the _ include files or "other not TAP tests" alone) to include the .test.js extension. In other word run something like

% mv test/agent.js test/agent.test.js

for every file that has TAP tests. Once this renaming is complete we'll want to change the collection of test files logic intest/test.js (not renamed because it's not a TAP file) to only run *.test.js files.

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jun 30, 2021
@trentm
Copy link
Member

trentm commented Jun 30, 2021

Another benefit (IMO) is having a file basename "foo.js" (in commands, stacktraces, editor tabs, whereever) unambigously refer to library code and "foo.test.js" to test code would be helpful.

Earlier discussion here: #2128 (comment)

FYI: some very much incomplete "migrate from tape to tap" PoC work here: https://github.com/elastic/apm-agent-nodejs/tree/trentm/tap/

@astorm astorm closed this as completed in 6fa6f95 Jul 6, 2021
dgieselaar pushed a commit to dgieselaar/apm-agent-nodejs that referenced this issue Sep 10, 2021
* feat: unifies TAP based tests with `[name].test.js` file naming convention

closes elastic#2137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

No branches or pull requests

2 participants