feat: ignore_message_queues configuration #2008

astorm · 2021-03-17T18:26:23Z

Partially implements: #1956

This PR adds the ignore_message_queues configuration to the agent. This is a prerequisite for supporting AWS SQS instrumentation. This PR does not include a CHANGELOG entry (that will come later, once the first messaging system (SQS) is added)

apmmachine · 2021-03-17T18:32:27Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #2008 updated
Start Time: 2021-03-18T22:59:46.090+0000
Duration: 15 min 40 sec
Commit: cad12bf

Test stats 🧪

Test	Results
Failed	0
Passed	16614
Skipped	0
Total	16614

Trends 🧪

apmmachine · 2021-03-17T18:39:32Z

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #2008 opened
Reason: Aborted from #4
Start Time: 2021-03-17T18:26:39.317+0000
Duration: 11 min 36 sec
Commit: beec9f5

Test stats 🧪

Test	Results
Failed	14
Passed	0
Skipped	0
Total	14

Trends 🧪

Test errors

Expand to view the tests failures

> Show only the first 10 test failures

`Test / Node.js-13 / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

`Test / Node.js-14.0-async-hooks-false / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

`Test / Node.js-12.0 / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

`Test / Node.js-12.0-async-hooks-false / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

`Test / Node.js-8.6 / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

`Test / Node.js-13-async-hooks-false / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

`Test / Node.js-12 / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

`Test / Node.js-10 / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

`Test / Node.js-12-async-hooks-false / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

`Test / Node.js-14.0 / [empty] – *-output-junit.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008/src/github.com/elastic/apm-agent-nodejs/*-output-junit.xml was length 0

Steps errors

Expand to view the steps failures

`Shell Script`

Took 0 min 0 sec . View more details on here
Description: docker run --rm -v $(pwd):/usr/src/app -w /usr/src/app -u $(id -u):$(id -g) node:12-alpine sh -c 'export HOME=/tmp ; mkdir ~/.npm-global; npm config set prefix ~/.npm-global ; npm install tap-xunit -g ; for i in "*-output.tap" ; do cat ${i} | /tmp/.npm-global/bin/tap-xunit --package="Node.js" > ${i%.*}-junit.xml ; done'

`Error signal`

Took 0 min 0 sec . View more details on here
Description: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

Log output

Expand to view the last 100 lines of log output

[2021-03-17T18:36:25.945Z] node_tests_1     | ok 3 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 4 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | # new Promise -> reject -> catch
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 5 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 6 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 7 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 8 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | # new Promise -> reject -> catch -> then
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 9 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 10 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 11 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 12 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 13 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 14 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 15 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 16 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | # new Promise -> reject -> then (2nd arg)
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 17 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 18 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 19 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 20 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | # Promise.resolve
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 21 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 22 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 23 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 24 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | # Promise.reject
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 25 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 26 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 27 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | ok 28 should be strictly equal
[2021-03-17T18:36:25.945Z] node_tests_1     | # Promise.all
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 29 should be deeply equivalent
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 30 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 31 should be deeply equivalent
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 32 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | APM Server transport error (ECONNREFUSED): connect ECONNREFUSED 127.0.0.1:8200
[2021-03-17T18:36:26.205Z] node_tests_1     | # Promise.race - 2nd resolve
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 33 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 34 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 35 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 36 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | # Promise.race - 1st resolve
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 37 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 38 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 39 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 40 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | # Promise.race - 2nd reject
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 41 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 42 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 43 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 44 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | # return new Promise
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 45 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 46 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 47 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 48 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 49 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 50 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 51 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 52 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 53 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 54 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 55 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | ok 56 should be strictly equal
[2021-03-17T18:36:26.205Z] node_tests_1     | 
[2021-03-17T18:36:26.205Z] node_tests_1     | 1..56
[2021-03-17T18:36:26.205Z] node_tests_1     | # tests 56
[2021-03-17T18:36:26.206Z] node_tests_1     | # pass  56
[2021-03-17T18:36:26.206Z] node_tests_1     | 
[2021-03-17T18:36:26.206Z] node_tests_1     | # ok
[2021-03-17T18:36:26.206Z] node_tests_1     | 
[2021-03-17T18:36:26.206Z] node_tests_1     | running (cwd: ./): node --require /app/test/_promise_rejection.js test/instrumentation/span.js
[2021-03-17T18:36:26.938Z] Cannot contact apm-ci-immutable-ubuntu-1804-1616005563293752844: hudson.remoting.RequestAbortedException: java.nio.channels.ClosedChannelException
[2021-03-17T18:37:04.205Z] Could not connect to apm-ci-immutable-ubuntu-1804-1616005563293752844 to send interrupt signal to process
[2021-03-17T18:37:04.234Z] Sleeping for 5 sec
[2021-03-17T18:37:09.606Z] Failed in branch Node.js-10.0-async-hooks-false
[2021-03-17T18:37:10.340Z] [INFO] getVaultSecret: Getting secrets
[2021-03-17T18:37:10.541Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-03-17T18:37:12.478Z] Stage "TAV Test" skipped due to earlier failure(s)
[2021-03-17T18:37:12.605Z] Stage "Edge Test" skipped due to earlier failure(s)
[2021-03-17T18:37:12.811Z] Stage "Nightly Test" skipped due to earlier failure(s)
[2021-03-17T18:37:12.837Z] Stage "Nightly Test - No async hooks" skipped due to earlier failure(s)
[2021-03-17T18:37:12.860Z] Stage "RC Test" skipped due to earlier failure(s)
[2021-03-17T18:37:12.883Z] Stage "RC Test - No async hooks" skipped due to earlier failure(s)
[2021-03-17T18:37:13.127Z] Failed in branch Nightly Test
[2021-03-17T18:37:13.154Z] Failed in branch Nightly Test - No async hooks
[2021-03-17T18:37:13.179Z] Failed in branch RC Test
[2021-03-17T18:37:13.206Z] Failed in branch RC Test - No async hooks
[2021-03-17T18:37:13.492Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-03-17T18:37:13.615Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-17T18:37:13.667Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-17T18:37:13.875Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2021-03-17T18:37:14.273Z] Running on Jenkins in /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2008
[2021-03-17T18:37:14.379Z] [INFO] getVaultSecret: Getting secrets
[2021-03-17T18:37:14.572Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-03-17T18:37:15.698Z] + chmod 755 generate-build-data.sh
[2021-03-17T18:37:15.698Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-2008/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-2008/runs/1 ABORTED 636103
[2021-03-17T18:37:15.948Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-2008/runs/1/steps/?limit=10000 -o steps-info.json
[2021-03-17T18:37:16.499Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-2008/runs/1/tests/?status=FAILED -o tests-errors.json

docs/configuration.asciidoc

Alan Storm added 3 commits March 17, 2021 10:54

feat: ignore_message_queues configuration

82d9c85

feat: docs

5a7c966

feat: typescript type

beec9f5

github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 17, 2021

Alan Storm added 2 commits March 17, 2021 11:27

fix: whitespace nit

8f7134c

fix: lint

cd10fbd

astorm marked this pull request as draft March 17, 2021 18:34

Merge branch 'master' into astorm/config-ignore-message-queue

914ad46

Alan Storm and others added 2 commits March 17, 2021 12:11

fix: makes type optional

b42840a

Merge branch 'master' into astorm/config-ignore-message-queue

0f15307

astorm marked this pull request as ready for review March 17, 2021 20:01

astorm requested review from bmorelli25 and trentm March 17, 2021 20:01

bmorelli25 reviewed Mar 17, 2021

View reviewed changes

docs/configuration.asciidoc Outdated Show resolved Hide resolved

bmorelli25 reviewed Mar 17, 2021

View reviewed changes

docs/configuration.asciidoc Outdated Show resolved Hide resolved

trentm reviewed Mar 17, 2021

View reviewed changes

docs/configuration.asciidoc Outdated Show resolved Hide resolved

docs/configuration.asciidoc Outdated Show resolved Hide resolved

docs/configuration.asciidoc Show resolved Hide resolved

AlexanderWert linked an issue Mar 18, 2021 that may be closed by this pull request

[META 408] Instrumentation for AWS SQS #1956

Closed

astorm requested a review from trentm March 18, 2021 22:57

Alan Storm added 2 commits March 18, 2021 15:59

fix: central config

e705f5a

fix: PR feedback -- central config, consistant grammar

cad12bf

trentm approved these changes Mar 18, 2021

View reviewed changes

astorm merged commit b4f4189 into master Mar 22, 2021

astorm deleted the astorm/config-ignore-message-queue branch March 22, 2021 14:02

trentm mentioned this pull request Mar 22, 2021

[META 408] Instrumentation for AWS SQS #1956

Closed

AlexanderWert removed a link to an issue Mar 22, 2021

[META 408] Instrumentation for AWS SQS #1956

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ignore_message_queues configuration #2008

feat: ignore_message_queues configuration #2008

astorm commented Mar 17, 2021

apmmachine commented Mar 17, 2021 •

edited

Loading

Build stats

Test stats 🧪

Trends 🧪

apmmachine commented Mar 17, 2021

Build stats

Test stats 🧪

Trends 🧪

`Test / Node.js-13 / [empty] – *-output-junit.xml`

`Test / Node.js-14.0-async-hooks-false / [empty] – *-output-junit.xml`

`Test / Node.js-12.0 / [empty] – *-output-junit.xml`

`Test / Node.js-12.0-async-hooks-false / [empty] – *-output-junit.xml`

`Test / Node.js-8.6 / [empty] – *-output-junit.xml`

`Test / Node.js-13-async-hooks-false / [empty] – *-output-junit.xml`

`Test / Node.js-12 / [empty] – *-output-junit.xml`

`Test / Node.js-10 / [empty] – *-output-junit.xml`

`Test / Node.js-12-async-hooks-false / [empty] – *-output-junit.xml`

`Test / Node.js-14.0 / [empty] – *-output-junit.xml`

`Shell Script`

`Error signal`

feat: ignore_message_queues configuration #2008

feat: ignore_message_queues configuration #2008

Conversation

astorm commented Mar 17, 2021

apmmachine commented Mar 17, 2021 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

Trends 🧪

apmmachine commented Mar 17, 2021

❕ Build Aborted

Build stats

Test stats 🧪

Trends 🧪

Test errors

Test / Node.js-13 / [empty] – *-output-junit.xml

Test / Node.js-14.0-async-hooks-false / [empty] – *-output-junit.xml

Test / Node.js-12.0 / [empty] – *-output-junit.xml

Test / Node.js-12.0-async-hooks-false / [empty] – *-output-junit.xml

Test / Node.js-8.6 / [empty] – *-output-junit.xml

Test / Node.js-13-async-hooks-false / [empty] – *-output-junit.xml

Test / Node.js-12 / [empty] – *-output-junit.xml

Test / Node.js-10 / [empty] – *-output-junit.xml

Test / Node.js-12-async-hooks-false / [empty] – *-output-junit.xml

Test / Node.js-14.0 / [empty] – *-output-junit.xml

Steps errors

Shell Script

Error signal

Log output

apmmachine commented Mar 17, 2021 •

edited

Loading

`Test / Node.js-13 / [empty] – *-output-junit.xml`

`Test / Node.js-14.0-async-hooks-false / [empty] – *-output-junit.xml`

`Test / Node.js-12.0 / [empty] – *-output-junit.xml`

`Test / Node.js-12.0-async-hooks-false / [empty] – *-output-junit.xml`

`Test / Node.js-8.6 / [empty] – *-output-junit.xml`

`Test / Node.js-13-async-hooks-false / [empty] – *-output-junit.xml`

`Test / Node.js-12 / [empty] – *-output-junit.xml`

`Test / Node.js-10 / [empty] – *-output-junit.xml`

`Test / Node.js-12-async-hooks-false / [empty] – *-output-junit.xml`

`Test / Node.js-14.0 / [empty] – *-output-junit.xml`

`Shell Script`

`Error signal`