Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implment awk-sdk v2 dynamodb instrumentation #2128

Merged
merged 18 commits into from
Jul 1, 2021
11 changes: 6 additions & 5 deletions .tav.yml
Original file line number Diff line number Diff line change
Expand Up @@ -413,14 +413,15 @@ body-parser:
- node test/sanitize-field-names/express.js

aws-sdk:
# We want a version range something like this:
# We want this version range:
# versions: '>=2.858 <3'
# However, awk-sdk releases *very* frequently (almost every day) and there
# is no need to test *all* those releases. Instead we statically list every
# N=5 releases to test.
# is no need to test *all* those releases. Instead we keep statically list
# every N=5 releases to test.
astorm marked this conversation as resolved.
Show resolved Hide resolved
#
# Maintenance note: This should be updated periodically.
versions: '2.876.0 || 2.881.0 || 2.886.0 || 2.891.0 || 2.896.0 || 2.901.0 || 2.906.0 || 2.911.0 || 2.916.0 || 2.921.0 || 2.926.0 || 2.931.0 || 2.936.0 || >2.918 <3'
# Maintenance note: This should be updated periodically, keeping 2.858
# as the earliest version but updating the others.
versions: '2.858.0 || 2.881.0 || 2.886.0 || 2.891.0 || 2.896.0 || 2.901.0 || 2.906.0 || 2.911.0 || 2.916.0 || 2.921.0 || 2.926.0 || 2.931.0 || 2.936.0 || >2.936 <3'
commands:
- node test/instrumentation/modules/aws-sdk/sqs.js
- node test/instrumentation/modules/aws-sdk/dynamodb.js
astorm marked this conversation as resolved.
Show resolved Hide resolved
5 changes: 3 additions & 2 deletions test/instrumentation/modules/aws-sdk/dynamodb.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@ const agent = require('../../../..').start({
secretToken: 'test',
captureExceptions: false,
astorm marked this conversation as resolved.
Show resolved Hide resolved
metricsInterval: 0,
centralConfig: false
centralConfig: 'none',
logLevel: 'off'
})
const tape = require('tape')
const AWS = require('aws-sdk')
const express = require('express')
const bodyParser = require('body-parser')
const fixtures = require('./fixtures-dynamodb')
const fixtures = require('./fixtures/dynamodb')

const mockClient = require('../../../_mock_http_client')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ module.exports = {
query: {
response: {
Count: 1,
Items:
[{ id: { S: '001' }, name: { S: 'Richard Roe' }, number: { N: '1' } }],
Items: [{ id: { S: '001' }, name: { S: 'Richard Roe' }, number: { N: '1' } }],
ScannedCount: 1
},
httpStatusCode: 200
Expand Down
2 changes: 1 addition & 1 deletion test/instrumentation/modules/aws-sdk/sqs.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const tape = require('tape')
const AWS = require('aws-sdk')
const express = require('express')
const bodyParser = require('body-parser')
const fixtures = require('./fixtures-sqs')
const fixtures = require('./fixtures/sqs')
const logging = require('../../../../lib/logging')
const mockClient = require('../../../_mock_http_client')

Expand Down