-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support node v17 #2380
feat: support node v17 #2380
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Otherwise the "test/start/..." tests that change the cwd and cannot find the relative path to our openssl config file: running (cwd: ./test/start/env): node --unhandled-rejections=strict test.test.js OpenSSL configuration error: C007EDBE107F0000:error:80000002:system library:BIO_new_file:No such file or directory:../deps/openssl/openssl/crypto/bio/bss_file.c:67:calling fopen(./test/openssl-config-for-testing.cnf, rb) C007EDBE107F0000:error:10000080:BIO routines:BIO_new_file:no such file:../deps/openssl/openssl/crypto/bio/bss_file.c:75: C007EDBE107F0000:error:07000072:configuration file routines:def_load:no such file:../deps/openssl/openssl/crypto/conf/conf_def.c:179: /home/runner/work/apm-agent-nodejs/apm-agent-nodejs/test/test.js:132 if (err) throw err This does not fail with node v16 and earlier. I don't know why. Perhaps it is the change to OpenSSL v3 in node v17.
Waiting on https://hub.docker.com/_/node "node:17" docker image for our Jenkins CI, which is waiting on docker-library/official-images#11138 to be fixed, which will then go through this process https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what |
|
…t request address This is a workaround for nodejs/node#40537
I'll add a changelog entry tomorrow, after I merge another change and update this branch, to avoid the merge conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look like the usual bit shifting between versions. 👍 Thanks for being on top of the Node.js release train. 🚋
This was broken in #2380. Versions of hapi <=16 did not support the 'host' option to `new Server`, but instead to `server.connection`.
#2387) This was broken in #2380. Versions of hapi <=16 did not support the 'host' option to `new Server`, but instead to `server.connection`. Also really old versions of fastify (v0.35.7) cannot even be npm installed with the npm included in node v17. This drops support for fastify <1.0.0 and updates the TAV test matrix to only test a given fastify version with its supported versions of node per https://www.fastify.io/docs/latest/LTS/
…reement on default from server and client (as discussed earlier here #2380 (comment))
Node v17.0.0 was released today per https://nodejs.org/en/about/releases/
We should officially add support (modulo this is not an LTS release). Adding to "engines" avoids this npm warning:
We will also add node v17 to list of versions we test.
Checklist