Better error handling for AWS token fetching #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out for docker containers on AWS elastic beanstalk, the PUT for the token fails, and fails slowly. This is not the case for the ec2 host on which the docker container is running. This was causing issues, compounded by the fact that I didn't have `retries=False` on that call.
This was referenced Jul 7, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
beniwohli
approved these changes
Jul 9, 2020
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Better error handling for AWS token fetching It turns out for docker containers on AWS elastic beanstalk, the PUT for the token fails, and fails slowly. This is not the case for the ec2 host on which the docker container is running. This was causing issues, compounded by the fact that I didn't have `retries=False` on that call. * Add changelog * Add comments about IMDSv2
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Better error handling for AWS token fetching It turns out for docker containers on AWS elastic beanstalk, the PUT for the token fails, and fails slowly. This is not the case for the ec2 host on which the docker container is running. This was causing issues, compounded by the fact that I didn't have `retries=False` on that call. * Add changelog * Add comments about IMDSv2
|
@elastic/apm-agent-devs one thing I missed when looking into this the first time is that not only we should expect the token query to fail, but that it still worth trying to retrieve the metadata even without the token |
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Better error handling for AWS token fetching It turns out for docker containers on AWS elastic beanstalk, the PUT for the token fails, and fails slowly. This is not the case for the ec2 host on which the docker container is running. This was causing issues, compounded by the fact that I didn't have `retries=False` on that call. * Add changelog * Add comments about IMDSv2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
It turns out for docker containers on AWS elastic beanstalk, the PUT for the
token fails, and fails slowly. This is not the case for the ec2 host on which
the docker container is running. This was causing issues, compounded by the
fact that I didn't have
retries=Falseon that call.I also made the timeouts shorter -- all of these calls are local, so they're very fast.
Related issues
Fixes #880