Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link to APM server 7.0 upgrade guide #1153

Merged
merged 1 commit into from
Feb 1, 2022
Merged

docs: update link to APM server 7.0 upgrade guide #1153

merged 1 commit into from
Feb 1, 2022

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jan 27, 2022

Updates a link to the APM Server 7.0 upgrade guide. This link doesn't exist in 8.0+ and will break when we release 8.0 GA.

NOTE: The link currently directs users to 7.17 so we may want to wait until after the 7.17 release before merging.

We'll also need to backport to 5.x.

Relates to elastic/docs#2312

Preview

https://apm-agent-rum-js_1153.docs-preview.app.elstc.co/guide/en/apm/agent/rum-js/master/upgrade-to-v5.html#v5-upgrade-server

@jrodewig jrodewig added the Team:Docs Label for the Observability docs team label Jan 27, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Jan 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-28T13:34:47.062+0000

  • Duration: 17 min 19 sec

  • Commit: 24f5742

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@ollyhowell ollyhowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devcorpio
Copy link
Contributor

devcorpio commented Jan 28, 2022

Hi @jrodewig

you may need to change the message of each of your commits to this format docs: <msg> to pass the Lint check. (You may need to update the PR title too)

@jrodewig jrodewig changed the title [DOCS] Update link to APM Server 7.0 upgrade guide docs: update link to APM Server 7.0 upgrade guide Jan 28, 2022
@jrodewig jrodewig changed the title docs: update link to APM Server 7.0 upgrade guide docs: update link to APM server 7.0 upgrade guide Jan 28, 2022
@jrodewig
Copy link
Contributor Author

Thanks for the pointer, @devcorpio!

@apmmachine
Copy link
Contributor

📦 Bundlesize report

Filename Size(bundled) Size(gzip) Diff(gzip)
elastic-apm-opentracing.umd.min.js 63.8 KiB 20.3 KiB 💚 0 Bytes
elastic-apm-rum.umd.min.js 57.7 KiB 18.8 KiB 💚 0 Bytes

@jrodewig
Copy link
Contributor Author

jrodewig commented Feb 1, 2022

@bmorelli25 Do you mind merging and backporting this to 5.x when convenient?

I'd do it myself, but I lack the permissions. ☹️

Thanks!

Screen Shot 2022-02-01 at 11 06 21 AM

@bmorelli25 bmorelli25 merged commit 68cdd09 into elastic:main Feb 1, 2022
@bmorelli25
Copy link
Member

Yup! Thanks, James!

bmorelli25 pushed a commit to bmorelli25/apm-agent-rum-js that referenced this pull request Feb 1, 2022
@jrodewig jrodewig deleted the docs__fix-7.0-update-link branch February 1, 2022 19:27
bmorelli25 added a commit that referenced this pull request Feb 1, 2022
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants