Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for reproducible builds #237

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

kruskall
Copy link
Member

Add support for SOURCE_DATE_EPOCH to avoid timestamp and timezones
issues.

See https://reproducible-builds.org/specs/source-date-epoch/

Make sure zip entries have a consistent mtime and strip extra
attributes.

See https://reproducible-builds.org/docs/archives/

Zip archives are now reproducible by default. Update script
to use the make task and avoid calling zip directly.

For more information see https://reproducible-builds.org/

Add support for SOURCE_DATE_EPOCH to avoid timestamp and timezones
issues.

See https://reproducible-builds.org/specs/source-date-epoch/

Make sure zip entries have a consistent mtime and strip extra
attributes.

See https://reproducible-builds.org/docs/archives/

Zip archives are now reproducible by default. Update script
to use the make task and avoid calling zip directly.
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jul 15, 2022
@apmmachine
Copy link

apmmachine commented Jul 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T14:26:50.280+0000

  • Duration: 16 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 224
Skipped 4
Total 228

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I wasn't aware of that spec. Looks good, just wondering if we should set a different default in the Makefile.

apm-lambda-extension/Makefile Outdated Show resolved Hide resolved
apm-lambda-extension/Makefile Outdated Show resolved Hide resolved
@kruskall kruskall requested a review from axw July 20, 2022 14:26
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!

@kruskall kruskall merged commit 65cd5df into elastic:main Jul 21, 2022
@kruskall kruskall deleted the feat/reproducible-builds branch July 21, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants