Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace timeout seconds option with timeout durations #294

Merged
merged 5 commits into from
Aug 31, 2022

Conversation

kruskall
Copy link
Member

Deprecate TIMEOUT_SECONDS options in favour of simpler TIMEOUT options.
The new options take a duration as a more user-friendly and flexible
input. It will always take precedence over the old option.
If the old option is provided, a warning is printed out.

Deprecate TIMEOUT_SECONDS options in favour of simpler TIMEOUT options.
The new options take a duration as a more user-friendly and flexible
input. It will always take precedence over the old option.
If the old option is provided, a warning is printed out.
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Aug 29, 2022
@apmmachine
Copy link

apmmachine commented Aug 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-31T00:41:04.123+0000

  • Duration: 8 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 2
Total 162

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like it! Just a couple of minor things.

app/app.go Outdated Show resolved Hide resolved
docs/monitoring-aws-lambda.asciidoc Show resolved Hide resolved
@simitt
Copy link
Contributor

simitt commented Aug 30, 2022

I am curious if you reviewed other configuration options also?
The lambda extension is GA, and I'd like to avoid spreading deprecations in separate releases. Instead, we should aim for reworking any existing config option that should be changed within the same release.

@kruskall
Copy link
Member Author

I am curious if you reviewed other configuration options also? The lambda extension is GA, and I'd like to avoid spreading deprecations in separate releases. Instead, we should aim for reworking any existing config option that should be changed within the same release.

Good question! I reviewed the other options but these are the only one that needed a rework IMO

@kruskall kruskall requested a review from axw August 30, 2022 20:04
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, but I can't see the rendered docs as there's a missing anchor.

docs/monitoring-aws-lambda.asciidoc Show resolved Hide resolved
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
@kruskall kruskall requested a review from axw August 31, 2022 00:23
@kruskall kruskall merged commit e8e26ed into elastic:main Aug 31, 2022
@kruskall kruskall deleted the feat/new-timeout-env branch August 31, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants