-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace timeout seconds option with timeout durations #294
Conversation
Deprecate TIMEOUT_SECONDS options in favour of simpler TIMEOUT options. The new options take a duration as a more user-friendly and flexible input. It will always take precedence over the old option. If the old option is provided, a warning is printed out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I like it! Just a couple of minor things.
I am curious if you reviewed other configuration options also? |
Good question! I reviewed the other options but these are the only one that needed a rework IMO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good, but I can't see the rendered docs as there's a missing anchor.
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
Deprecate TIMEOUT_SECONDS options in favour of simpler TIMEOUT options.
The new options take a duration as a more user-friendly and flexible
input. It will always take precedence over the old option.
If the old option is provided, a warning is printed out.