Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process platform report metrics when extn is lagging #358

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Jan 10, 2023

The current extension will drop the platform.report logs if the platform report metrics are reported in an invocation that does not immediately succeed in the invocation generating the platform report. To prevent the logs from getting dropped the PR does the following changes:

  1. Updates the lifecycle of the cached invocation data to be cleared on receiving platform.report metric for its corresponding request ID.
  2. Query the cached invocation data instead of using the previous event and drop the log event if the prev event doesn't match the event's request ID.

Part of #334

@lahsivjar lahsivjar requested a review from a team January 10, 2023 07:22
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jan 10, 2023
@apmmachine
Copy link

apmmachine commented Jan 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-12T08:51:15.772+0000

  • Duration: 6 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 204
Skipped 2
Total 206

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lahsivjar
Copy link
Contributor Author

Apologies for the push after marking it ready for review. I realized there was an edge case when on shutdown there might be more than one platform.report pending. I have fixed this now.

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lahsivjar lahsivjar enabled auto-merge (squash) January 12, 2023 06:01
@lahsivjar
Copy link
Contributor Author

/test

@lahsivjar lahsivjar merged commit 3963b5a into elastic:main Jan 12, 2023
@lahsivjar lahsivjar deleted the 334-fix-pf-report branch January 12, 2023 08:57
@lahsivjar lahsivjar mentioned this pull request Feb 20, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants