fix: only flush logs if logs collection is enabled #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but can you also add a test for when there is no log collection? |
rockdaboot
reviewed
Jul 25, 2024
| @@ -96,8 +96,10 @@ func (app *App) Run(ctx context.Context) error { | |||
| backgroundDataSendWg.Wait() | |||
| if event.EventType == extension.Shutdown { | |||
| app.logger.Infof("Exiting due to shutdown event with reason %s", event.ShutdownReason) | |||
| // Flush buffered logs if any | |||
| app.logsClient.FlushData(ctx, event.RequestID, event.InvokedFunctionArn, app.apmClient.LambdaDataChannel, true) | |||
| if app.logsClient != nil { | |||
There was a problem hiding this comment.
Alternatively, check lc for nil in FlushData and return early (slightly reduces number of lines changed).
19 tasks
There is no coverage/test for the app when logs collection is disabled Add a testcase to ensure standard events chain work even if logs collection is disabled.
rockdaboot
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If logs collection is disabled or logs subscription failed then
logsClientis nil