Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

chore: refactor filebeat step #1049

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

kuisathaverat
Copy link
Contributor

What does this PR do?

  • Minor refactor of the output variable use
  • Avoid hiding errors when the container is not launched.
    • Bump the container version

Why is it important?

When an error happens during the execution of the Docker container, it always shows an error reading the config file but there is one error before that.

@kuisathaverat kuisathaverat requested a review from a team March 23, 2021 16:20
@kuisathaverat kuisathaverat self-assigned this Mar 23, 2021
@botelastic botelastic bot added the groovy label Mar 23, 2021
@kuisathaverat kuisathaverat changed the title chore: refactor chore: refactor filebeat step Mar 23, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Mar 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1049 updated

  • Start Time: 2021-03-24T12:06:46.194+0000

  • Duration: 31 min 24 sec

  • Commit: 8f63097

Test stats 🧪

Test Results
Failed 0
Passed 1080
Skipped 2
Total 1082

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1080
Skipped 2
Total 1082

Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, although there is a test error

@kuisathaverat kuisathaverat added automation enhancement New feature or request Team:Automation Label for the Observability productivity team labels Mar 23, 2021
@kuisathaverat kuisathaverat merged commit cf48f5d into elastic:master Mar 24, 2021
v1v referenced this pull request in v1v/apm-pipeline-library Apr 6, 2021
* 'master' of github.com:elastic/apm-pipeline-library: (40 commits)
  Fix and simplify buildStatus step (#1066)
  Add benchmark reporter image to build pipeline (#1065)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.207
  feat: stage status cache (#1061)
  feat: step hasCommentAuthorWritePermissions (#1064)
  ARM workers are now ephemeral (#1062)
  docs: update metricbeat step docs (#1057)
  Update beats-ci workers for the test-infra validation (#1058)
  feat: allow to remove padding (#1059)
  mergify: priority is now a pro feature (#1060)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.206
  chore(deps): bump groovy-eclipse-batch from 3.0.7-02 to 3.0.7-03 (#1045)
  chore: bump Elastic Stack versions (#1052)
  Add GCE JCasC (#1053)
  feat: metricbeat step (#1050)
  chore: refactor filebeat step (#1049)
  ...
@kuisathaverat kuisathaverat deleted the filebeat_refactor branch July 19, 2021 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation enhancement New feature or request groovy Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants