Fix build status and adjust Vault #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kuisathaverat
approved these changes
Apr 14, 2021
v1v
reviewed
Apr 14, 2021
v1v
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
I did a quick search for https://github.com/search?l=Groovy&q=org%3Aelastic+readSecret&type=Code and I couldn not find any other consumers
+1
v1v
added a commit
that referenced
this pull request
Apr 21, 2021
…notify-message-template * upstream/master: Fix build status and adjust Vault (#1074) Remove super-linter since it takes 20 minutes (#1083) Bump elastic stack version automation (#1081) feat: step to check if a docker image exists (#1077) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.210 Enable stage filter argument for the beatsStages (#1076)
v1v
referenced
this pull request
in v1v/apm-pipeline-library
Apr 22, 2021
…automation * upstream/master: Add searchIssuesWithFilters action for the lookForGitHubIssues (#1082) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.211 Fix build status and adjust Vault (#1074) Remove super-linter since it takes 20 minutes (#1083)
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This contains a variety of fixes which related to the Jenkins release job for the apm-java-agent project.
Build Status
The previous step used the standard library to make HTTP requests. However, it was silently failing and returning incorrect results. We change to use our existing HTTP client implementation which works more reliably and returns the correct result.
Make vault credentials configurable
The
internal-cimachine is shared between multiple teams and our credentials are namespaced accordingly. Therefore, I modified the Vault implementation to make it possible to pass in specific IDs to use when authenticating to Vault.Why is it important?
Fixes issues related to the broken release job for the APM Java agent.
Related issues
https://github.com/elastic/observability-robots/issues/463