-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate nightly benchmarks to GH Actions #11071
Conversation
This pull request does not have a backport label. Could you fix it @reakaleek? 🙏
NOTE: |
📚 Go benchmark reportDiff with the
report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
b71ef66
to
aff7709
Compare
This pull request is now in conflicts. Could you fix it @reakaleek? 🙏
|
aff7709
to
ab0f92d
Compare
ab0f92d
to
726e56f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 ++ thank you!
Would it theoretically be possible for us to add workflow_dispatch
later? I would love to be able to easily trigger the benchmarks off an arbitrary branch.
Co-authored-by: Andrew Wilkins <axw@elastic.co>
Yes, I was planning to do this in a follow up and discuss with you. But since you already mentioned |
Motivation/summary
Migrate nightly benchmarks from Jenkins to GH Actions
How to test these changes
Tested here: https://github.com/elastic/apm-server/actions/runs/5412428491